Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated.ip): modify step4 no geolocation message #13622

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat(dedicated.ip): modify step4 no geolocation message #13622

merged 2 commits into from
Nov 14, 2024

Conversation

sachinrameshn
Copy link
Contributor

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15656
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

@sachinrameshn sachinrameshn requested a review from a team as a code owner October 16, 2024 11:36
qpavy
qpavy previously approved these changes Oct 16, 2024
View reviewed changes
ghyenne
ghyenne previously approved these changes Oct 16, 2024
View reviewed changes
tristanwagner
tristanwagner previously approved these changes Oct 16, 2024
View reviewed changes
@sachinrameshn sachinrameshn changed the base branch from master to release/infra-hpc-w47 November 14, 2024 16:31
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sachinrameshn sachinrameshn merged commit 79db20e into release/infra-hpc-w47 Nov 14, 2024
13 of 14 checks passed
@sachinrameshn sachinrameshn deleted the feat/MANAGER-15656 branch November 14, 2024 17:11
@sachinrameshn sachinrameshn mentioned this pull request Nov 14, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhelhali-soufien mhelhali-soufien mhelhali-soufien approved these changes

@darsene darsene darsene approved these changes

@ghyenne ghyenne ghyenne left review comments

@tristanwagner tristanwagner tristanwagner left review comments

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@qpavy qpavy Awaiting requested review from qpavy

Assignees
No one assigned
Labels
feature New feature quality check: ok translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sachinrameshn @qpavy @tristanwagner @ghyenne @darsene @mhelhali-soufien