Feat/pci ai notebooks manage notebook pop up (Start, Stop, Delete) #13860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
has conflicts
Base automatically changed from
feat/pci-ai-notebooks-order-funnel
to
feat/pci-ai-notebooks-epic
November 14, 2024 16:10
DATATR-1548 Signed-off-by: Arthur Bullet <[email protected]>
ref:DATATR-1548 Signed-off-by: Arthur Bullet <[email protected]>
ref:DATATR-1548 Signed-off-by: Arthur Bullet <[email protected]>
ref:DATATR-1548 Signed-off-by: Arthur Bullet <[email protected]>
DATATR-1548 Signed-off-by: Arthur Bullet <[email protected]>
DATATR-1548 Signed-off-by: Arthur Bullet <[email protected]>
ref:DATATR-1559,DATATR-1560,DATATR-1561 Signed-off-by: Arthur Bullet <[email protected]>
abullet33
force-pushed
the
feat/pci-ai-notebooks-manage-notebook
branch
from
ededb2f
to
7e269d1
Compare
github-actions
bot
removed
the
has conflicts
Signed-off-by: Arthur Bullet <[email protected]>
abullet33
requested review from
sidlynx,
kqesar,
antonymarion,
darsene,
mhelhali-soufien,
jperchoc and
a team
and removed request for
a team
|
jperchoc
reviewed
Nov 14, 2024
Comment on lines
+25
to
+27
| queryClient.invalidateQueries({ | ||
| queryKey: [projectId, 'ai/notebook'], | ||
| }); |
There was a problem hiding this comment.
Should we also invalidate this query ? const queryKey = [projectId, 'ai/notebook', notebookId];
Comment on lines
+22
to
+24
| queryClient.invalidateQueries({ | ||
| queryKey: [projectId, 'ai/notebook'], | ||
| }); |
There was a problem hiding this comment.
Same here, maybe we need to invalidate the getNotebook query
There was a problem hiding this comment.
It seems that there is temporary code in this file, can you remove it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:DATATR-1559,DATATR-1560,DATATR-1561
master/release/**/developDescription
Related