Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-ai-endpoints): create AI Endpoints react app #13928

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat(pci-ai-endpoints): create AI Endpoints react app #13928

wants to merge 11 commits into from
+953 −31

Conversation

Masta2000
Copy link

ref:AIS-859

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets AIS-859
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Create react-app for AI Endpoints

Related

@Masta2000 Masta2000 requested review from a team as code owners November 5, 2024 08:25
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Nov 5, 2024
abullet33
abullet33 previously approved these changes Nov 13, 2024
View reviewed changes
tristanwagner
tristanwagner requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tristanwagner tristanwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix sonarcloud issues and more importantly this one

tristanwagner
tristanwagner previously approved these changes Nov 13, 2024
View reviewed changes
anooparveti
anooparveti requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the folders e2e, mocks and playwright.config.ts

packages/manager/apps/pci-ai-endpoints/public/translations/onboarding/Messages_fr_FR.json Outdated Show resolved Hide resolved
packages/manager/apps/pci-ai-endpoints/src/components/Error/Error.tsx Outdated Show resolved Hide resolved
@abullet33 abullet33 force-pushed the feat/ai-apps branch 2 times, most recently from 6a2c3dd to 6f79dc4 Compare November 14, 2024 09:18
@abullet33 abullet33 changed the base branch from master to develop November 14, 2024 09:18
Chris Fradet added 3 commits November 14, 2024 14:39
darsene and others added 7 commits November 14, 2024 14:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abullet33 abullet33 abullet33 left review comments

@anooparveti anooparveti anooparveti requested changes

@tristanwagner tristanwagner tristanwagner left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
container dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Masta2000 @tristanwagner @anooparveti @abullet33 @darsene