feat(pci-gateway): review design #14038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqesar
force-pushed
the
feat/DTCORE-2809
branch
from
5fb0843
to
16eb42c
Compare
frenautvh
previously approved these changes
Nov 12, 2024
darsene
reviewed
Nov 13, 2024
Comment on lines
41
to
43
| <> | ||
| <ActionMenu items={items} isCompact /> | ||
| </> |
There was a problem hiding this comment.
Sonar issue. Fragment is not necessary here
Comment on lines
115
to
117
| headerButton={ | ||
| <PciGuidesHeader category="instances"></PciGuidesHeader> | ||
| } |
There was a problem hiding this comment.
niptick : autoclose element is shorter
Suggested change
| headerButton={ | |
| <PciGuidesHeader category="instances"></PciGuidesHeader> | |
| } | |
| headerButton={<PciGuidesHeader category="instances" />} |
kqesar
force-pushed
the
feat/DTCORE-2809
branch
from
16eb42c
to
0841057
Compare
kqesar
force-pushed
the
feat/DTCORE-2809
branch
from
0841057
to
beb2f7c
Compare
ref: DTCORE-2809 Signed-off-by: Yoann Fievez <[email protected]>
kqesar
force-pushed
the
feat/DTCORE-2809
branch
from
beb2f7c
to
e859f07
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: DTCORE-2809
master/release/**/developDescription
Related