Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tailwind-config): remove ods-size dependency #14098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(tailwind-config): remove ods-size dependency #14098

wants to merge 1 commit into from

Conversation

tristanwagner
Copy link
Contributor

@tristanwagner tristanwagner commented Nov 14, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

These css variables doesn't exist anymore in ODS v18, I replaced it with their actual value that they had in ODS v17

Related

@tristanwagner
fix(tailwind-config): remove ods-size dependency
dbac4af 
These css variables doesn't exist anymore in ODS v18, I replaced it with
their actual value that they had in ODS v17

Signed-off-by: Tristan WAGNER <[email protected]>
@tristanwagner tristanwagner self-assigned this Nov 14, 2024
@github-actions github-actions bot added common bug Something isn't working labels Nov 14, 2024
@tristanwagner tristanwagner marked this pull request as ready for review November 14, 2024 15:32
@tristanwagner tristanwagner requested a review from a team as a code owner November 14, 2024 15:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tristanwagner
Copy link
Contributor Author

here is where I found the corresponding values in the ods repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@tristanwagner tristanwagner

Labels
bug Something isn't working common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanwagner @aboungnaseng-ovhcloud