-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] add test to disable email notifications by federated user #10996
base: master
Are you sure you want to change the base?
Conversation
a646184
to
294259f
Compare
294259f
to
aa3ccac
Compare
488fa5a
to
c6d8269
Compare
c6d8269
to
5fe3203
Compare
5fe3203
to
f755bf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current ocm setup doesn't throw any notification related to federated share. So i don't see any sense on adding step related to federated share. Did we get confirmation from developer how they going to implement federated share notification? developer can make different event for federated share and internal share.
If developer make different event then our scenario doesn't work like it should work.
So until developer implement feature or confirm us about concept and event type we should not add such scenario in assumption basis
Alright then! If that's the case, should we halt this PR and other OCM notification related PRs for now? |
@prashant-gurung899 i think you can get confirmation from developer about event type. |
I have confirmed with the developer that the event name for OCM shares will include the term |
so disabling email notification will disable all email (internal email and federated email) ? |
That's what the expected behaviour is. We aren't sure as OCM notifications aren't implemented yet. |
Signed-off-by: prashant-gurung899 <[email protected]>
f755bf3
to
eb7163e
Compare
|
If the OCM notification events are not implemented yet then IMO we should wait for the implementation before adding the tests. Because we don't know what the behaviour and expectations will be. If everything follows our test expectations, then that's good. We can hold this until the implementation. |
Okay! I am holding my OCM notification PRs until further implementation. |
Please, move it to the backlog blocked |
Moving this PR to backlog blocked because OCM notification events are not implemented yet. See comment. |
Description
This PR adds test for disabling mail notification by federated user.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: