[full-ci][tests-only]Add support to update running service in ociswrapper #11003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
requested review from
anon-pradip,
ishabaral,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
nabim777,
S-Panta and
nirajacharya2
3 tasks
amrita-shrestha
force-pushed
the
add-support-to-update-restart-ocis-service
branch
from
76def2d to
aaa382d
Compare
amrita-shrestha
force-pushed
the
add-support-to-update-restart-ocis-service
branch
from
aaa382d to
8600467
Compare
|
saw-jan
reviewed
Feb 19, 2025
Comment on lines
+326
to
+328
| message := fmt.Sprintf("Service %s stopped successfully", service) | ||
| log.Println(message) | ||
| return true, fmt.Sprintf(message) |
There was a problem hiding this comment.
Suggested change
| message := fmt.Sprintf("Service %s stopped successfully", service) | |
| log.Println(message) | |
| return true, fmt.Sprintf(message) | |
| return true, fmt.Sprintf("Service %s stopped successfully", service) |
| @@ -364,7 +361,7 @@ func WaitForServiceStatus(service string, waitForUp bool) bool { | |||
| log.Println(fmt.Sprintf("%s service is not ready on port %d. %v", service, port, err)) | |||
| } else { | |||
| if err != nil { | |||
| log.Println(fmt.Sprintf("%s service port %d is no longer reachable", service, port)) | |||
| log.Println(fmt.Sprintf("%s service port %d is no longer reachable", service, port)) | |||
There was a problem hiding this comment.
Suggested change
| log.Println(fmt.Sprintf("%s service port %d is no longer reachable", service, port)) | |
| log.Println(fmt.Sprintf("%s service port %d is no longer reachable", service, port)) |
| for key, value := range envBody { | ||
| serviceEnvMap = append(serviceEnvMap, fmt.Sprintf("%s=%v", key, value)) | ||
| ocis.ServiceEnvConfigs = append(serviceEnvMap, fmt.Sprintf("%s=%v", key, value)) |
There was a problem hiding this comment.
we need to store envs separately for different services. So maybe:
ServiceEnvConfigs = ["serviceA" => [...envs], "serviceB" => [...envs]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add support to update running service with extra env.
Tests cases
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: