[tests-only][full-ci] Test coverage for federated user trying to delete deleted federation connection #11017
+16
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anon-pradip
force-pushed
the
test/test-coverage-for-deleted-user
branch
from
a1b5880 to
7888b35
Compare
16 tasks
anon-pradip
force-pushed
the
test/test-coverage-for-deleted-user
branch
from
7888b35 to
935ba4c
Compare
anon-pradip
changed the title
anon-pradip
requested review from
amrita-shrestha,
saw-jan,
prashant-gurung899,
nabim777,
PrajwolAmatya and
nirajacharya2
saw-jan
approved these changes
Feb 19, 2025
saw-jan
reviewed
Feb 19, 2025
| @@ -132,3 +132,13 @@ Feature: delete federated connections | |||
| } | |||
| } | |||
| """ | |||
|
|
|||
| @issue-10223 | |||
| Scenario: federated user tries to delete previously deleted federated connection | |||
There was a problem hiding this comment.
also, try to test these behaviors if possible
#10223 (comment)
There was a problem hiding this comment.
Okeii.. I will make another follow-up PR. 👍
anon-pradip
force-pushed
the
test/test-coverage-for-deleted-user
branch
from
935ba4c to
9f8585e
Compare
|
LGTM 👍 |
amrita-shrestha
requested changes
Feb 20, 2025
tests/acceptance/features/apiOcm/deleteFederatedConnections.feature
Outdated
Show resolved
Hide resolved
anon-pradip
force-pushed
the
test/test-coverage-for-deleted-user
branch
2 times, most recently
from
85d12e5 to
6094f61
Compare
anon-pradip
force-pushed
the
test/test-coverage-for-deleted-user
branch
from
6094f61 to
1a5d5cd
Compare
| @issue-10223 | ||
| Scenario: federated user tries to delete previously deleted federated connection | ||
| Given user "Brian" has deleted federated connection with user "Alice" | ||
| When user "Brian" tries to delete federated connection with user "Alice" using the Graph API |
There was a problem hiding this comment.
Would the behavior be same if Alice tries to delete the federated connection here?
There was a problem hiding this comment.
Yes. It gives 400 (Bad request) when Alice tries to delete the federated connection that has already been deleted by her. We can have test coverage for this scenario also. Will add in the follow-up PR.
There was a problem hiding this comment.
better to add in this PR, rather than follow-up
anon-pradip
force-pushed
the
test/test-coverage-for-deleted-user
branch
from
1a5d5cd to
8aad2a1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds up the following scenario to test:
federated user trying to delete deleted federation connectionRelated Issue
Part of: #10971
Bug report: #10223
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: