Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Fix the SpaceMembershipExpired event #11079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[full-ci] Fix the SpaceMembershipExpired event #11079

wants to merge 1 commit into from
+25 −18

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Feb 27, 2025 •
edited
Loading

Description

We fixed the SpaceMembershipExpired event emitting.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 force-pushed the issue-10882 branch 2 times, most recently from 801bbb9 to 5a95510 Compare February 28, 2025 08:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@2403905 2403905 marked this pull request as ready for review February 28, 2025 15:20
@2403905 2403905 requested a review from kobergj February 28, 2025 15:20
@2403905 2403905 mentioned this pull request Feb 28, 2025
Open
@prashant-gurung899
Copy link
Contributor

I have tested from this PR and works fine. Sometimes, there are multiple notifications triggered for same event and that's reported here :#10936
in-app-space-expiry
email-space-expiry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj Awaiting requested review from kobergj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No notification for expired space membership event
2 participants
@2403905 @prashant-gurung899