-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oxlint): current dir as arg #9382
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
my windows setup is broken. |
|
a9284da
to
2ce2ec2
Compare
Ok so using If that's still problematic I think we'd have to use a crate like normalize_path instead. Or manually handle each edge case. |
closes #9023
When passing
.
as an arg it would result in a path like{cwd}/.
, which when being used to resolve other paths obviously caused issues. This canonicalizes any path args before doing anything else.Adds test to verify this based on original issue. This also caused another snapshot to change for an invalid file extension, changing from
LintSucceeded
toLintNoFilesFound
, which I believe is actually correct? If you only pass files that do not exist it would make more sense to return an error to me so I'm viewing this as a side effect fix.