Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(parser): pre-allocate enough space in ArrayExpression and ObjectExpressions conversion #9776

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 14, 2025

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance labels Mar 14, 2025
Copy link
Member Author

Dunqing commented Mar 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #9776 will not alter performance

Comparing 03-14-perf_parser_pre-allocate_enough_space_in_arrayexpression_and_objectexpressions_conversion (f225ca4) with main (ea7e3f0)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 14, 2025
Copy link
Member

Boshen commented Mar 14, 2025

Merge activity

  • Mar 14, 5:06 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 14, 5:06 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 14, 9:12 AM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.

@graphite-app graphite-app bot force-pushed the 03-14-refactor_parser_simplify_parsing_extends_clause branch from 63e0c9a to 3945385 Compare March 14, 2025 09:06
graphite-app bot pushed a commit that referenced this pull request Mar 14, 2025
@graphite-app graphite-app bot force-pushed the 03-14-perf_parser_pre-allocate_enough_space_in_arrayexpression_and_objectexpressions_conversion branch from 7602399 to 23d149b Compare March 14, 2025 09:07
@Dunqing Dunqing marked this pull request as draft March 14, 2025 09:08
Base automatically changed from 03-14-refactor_parser_simplify_parsing_extends_clause to main March 14, 2025 09:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 14, 2025
@Dunqing Dunqing force-pushed the 03-14-perf_parser_pre-allocate_enough_space_in_arrayexpression_and_objectexpressions_conversion branch from 23d149b to a4549f8 Compare March 14, 2025 09:16
@Dunqing
Copy link
Member Author

Dunqing commented Mar 14, 2025

I've triggered the benchmark a few times, and from the benchmark result, it turns out this is a deoptimization. I will dig into it a little later.

…in_arrayexpression_and_objectexpressions_conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants