Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs: 1) unscaled norm computation in info.jl; 2) robust infe… #179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yuwenchen95
Copy link
Collaborator

@yuwenchen95 yuwenchen95 commented Oct 30, 2024

The commit aims to fix two issues:

  1. correct unscaling variables in the norm computation (info.jl);
  2. make infeasibility more robust & correct the reduced infeasibility parameter.

We should also make the same update in Clarabel.rs.

…asibility detection & fix the reduced infeasibility tolerance
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.53%. Comparing base (6c822bc) to head (3d0ac79).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/info.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   85.44%   85.53%   +0.09%     
==========================================
  Files          58       58              
  Lines        4472     4473       +1     
==========================================
+ Hits         3821     3826       +5     
+ Misses        651      647       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant