Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many in connections #213

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Many in connections #213

wants to merge 4 commits into from

Conversation

ExMix
Copy link

@ExMix ExMix commented Mar 2, 2019

No description provided.

@Daguerreo
Copy link

I merged it in my fork, seems to work like a charm. As for now the approach seems more reliable of adding dynamic ports.

@Daguerreo
Copy link

I noticed this PR broke the converters. ModuloModel in calculator example stop working after this.

@Daguerreo
Copy link

Daguerreo commented Dec 21, 2020

I figured out. It was the converter in Connection passed by copy which cause the shared_ptr to be deleted after been sent to NodeDataModel::setInData().

Connection.hpp, turn
TypeConverter typeConverter() const;

to

TypeConverter& typeConverter();
Connection.cpp

TypeConverter& Connection::TypeConverter()
{
    return _converter;
}

Node.cpp line 201
change
TypeConverter converter = c->GetTypeConverter();
to
auto& converter = c->typeConverter();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants