Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPAE-1865] Display the total search result count #6839

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented Mar 20, 2025

This PR depends on #6800

Short description

This PR allows displaying the total number of search results.

Details

count
file.mp4

List of changes proposed in this pull request

  • Added a ListItemHeader component above the list to display the total number of results
  • Added the ServiceListSkeleton component to display a skeleton while lists are loading
  • Update locales

How to test

  • Perform a search in the services section
    • If results are found, the total number should be displayed above the list
    • If no results are found, the count should not be displayed

@adelloste adelloste added the IO-Enti e Servizi IO - Enti e Servizi label Mar 20, 2025
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 20, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@adelloste adelloste changed the title [IOPAE-1865] Display the total search result count feat [IOPAE-1865] Display the total search result count Mar 20, 2025
@adelloste adelloste changed the title feat [IOPAE-1865] Display the total search result count feat: [IOPAE-1865] Display the total search result count Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 50.84%. Comparing base (6fb3723) to head (64e9989).

Files with missing lines Patch % Lines
.../features/services/search/screens/SearchScreen.tsx 0.00% 6 Missing ⚠️
...services/common/components/ServiceListSkeleton.tsx 64.28% 5 Missing ⚠️
...tures/services/home/screens/ServicesHomeScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6839      +/-   ##
==========================================
- Coverage   50.84%   50.84%   -0.01%     
==========================================
  Files        1612     1611       -1     
  Lines       33622    33627       +5     
  Branches     7585     7590       +5     
==========================================
+ Hits        17096    17097       +1     
- Misses      16479    16484       +5     
+ Partials       47       46       -1     
Files with missing lines Coverage Δ
...features/services/common/components/EmptyState.tsx 40.00% <ø> (ø)
...ures/services/common/components/ServicesHeader.tsx 100.00% <ø> (ø)
.../institution/screens/InstitutionServicesScreen.tsx 78.18% <ø> (ø)
...tures/services/home/screens/ServicesHomeScreen.tsx 3.12% <0.00%> (ø)
...services/common/components/ServiceListSkeleton.tsx 64.28% <64.28%> (ø)
.../features/services/search/screens/SearchScreen.tsx 6.77% <0.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb3723...64e9989. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

dpulls bot commented Mar 21, 2025

🎉 All dependencies have been resolved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Enti e Servizi IO - Enti e Servizi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant