Done! :D #102
Open
Done! :D #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybobo
reviewed
May 10, 2018
|
|
||
| if integer >= 90 | ||
| "A" | ||
| elsif integer < 90 && integer >= 80 |
There was a problem hiding this comment.
if you go this route with a guard clause of sorts keep in mind that case statements and ranges are also an option.
case integer
when 80..90
...
end
jaybobo
reviewed
May 10, 2018
|
|
||
| #Put your code here! | ||
|
|
||
| array.sort_by {|word| word.length}.first |
There was a problem hiding this comment.
'.min_by' is a handy little ruby function that will make this a bit more concise.
https://ruby-doc.org/core-2.5.0/Enumerable.html#method-i-min_by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo