-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demonstration] Working Conjure compiler graal native-image #780
base: master
Are you sure you want to change the base?
Conversation
conjure/resourceconfig.json
Outdated
{ | ||
"resources": { | ||
"includes": [ | ||
{"pattern": "^(.(?!.*\\.class))*$"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear if the .class
extension exclusion is necessary, I was debugging other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an ideal world we'd be able to do this programatically using a build Feature like reflection to reduce dependence on custom configs.
&& !name.contains("shaded") | ||
&& !name.contains("glassfish") | ||
&& !name.startsWith("javax") | ||
&& !name.startsWith("jakarta")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was whac-a-mole.
This reduces the size from 270m to 48m Only include reflection data for types with runtime retained annotations, excluding several which don't have a high correlation with reflective use (e.g. Deprecated, Documetned).
1bb1b7a
to
792729f
Compare
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
NOT for merge
==COMMIT_MSG==
Demonstration working Conjure compiler graal native-image
==COMMIT_MSG==