Per host channels #1333
Draft
Per host channels #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkozlowski
force-pushed
the
jakubk/per-host-stick
branch
from
f05d200
to
0f2942a
Compare
carterkozak
reviewed
Jul 16, 2021
| return endpoint(endpoint).execute(request); | ||
| } | ||
| }) | ||
| .collect(ImmutableList.toImmutableList()); |
There was a problem hiding this comment.
I think this piece is more or less the alternative described here, except that we don't leverage it from the StickySessionFactory.
There was a problem hiding this comment.
Yeah: I think it's valuable to provide wholesale fairness implementation. If we're not going to ship the whole thing (i.e. you can support internal usecase for per-transaction fairness, with ability to create a new sticky channel from an existing sticky channel with new queue), I'd be happy to switch to per-host queues even for sticky channels. The reason I added it in #1334 is because I wanted to ship the whole thing.
carterkozak
reviewed
Jul 16, 2021
dialogue-core/src/main/java/com/palantir/dialogue/core/NodeSelectingChannel.java
Outdated
Show resolved
Hide resolved
jkozlowski
force-pushed
the
jakubk/stick-queue
branch
from
b98c9b0
to
36e4faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?