Set a small socket timeout before closing partially consumed responses #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a degenerate case in which closure isn't negotiated in a timely manner, and the client consumes far more bytes than desired in `SSLSocketInputRecord.deplete`.
Generate changelog in
|
carterkozak
force-pushed
the
ckozak/terrible_hack_socket_timeout
branch
from
ab754af
to
567a855
Compare
schlosna
reviewed
Feb 1, 2023
| : "Expected ConnectionEndpointAccess.getConnectionEndpoint " | ||
| + "to extract a ConnectionEndpoint"; | ||
| if (maybeEndpoint != null) { | ||
| maybeEndpoint.setSocketTimeout(Timeout.ONE_MILLISECOND); |
There was a problem hiding this comment.
Should we set this to 0 so that the deplete tryToRead arg is false
- https://github.com/openjdk/jdk17u/blob/2fe42855c48c49b515b97312ce64a5a8ef3af407/src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java#L1221
- https://github.com/openjdk/jdk17u/blob/0a6252780a862e6d5646a28c2b22a1c03eff37bf/src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java#L494
There was a problem hiding this comment.
I don't think so -- that would only skip the single-byte read call, not the skip where most of the time is spent in a loop (with potentially no timeout)
There was a problem hiding this comment.
Yeah, makes sense so we should expect the skip to timeout after 1ms with no bytes
|
With some adjustments this could also handle #1814. |
|
Yep, I'd thought the same thing -- planning to take a look at it after some issues I'm currently digging into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a degenerate case in which closure isn't negotiated in a timely manner, and the client consumes far more bytes than desired in
SSLSocketInputRecord.deplete.After this PR
==COMMIT_MSG==
Set a small socket timeout before closing partially consumed responses
==COMMIT_MSG==