Dialogue attempts not to retain context classloaders #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
jkozlowski
reviewed
Apr 19, 2023
| .build()); | ||
| // Ideally we would use a name pattern like 'dialogue-cleaner-%d', however it's more important | ||
| // that this cleaner does not retain context classloader references. | ||
| private static final Cleaner cleaner = Cleaner.create(); |
There was a problem hiding this comment.
Could not use ThreadFactoryBuilder and impl from scratch?
There was a problem hiding this comment.
Not quite, cleaner has some special case logic to clear threadlocal data after cleaning objects when the thread implementation is the internal default (InnocuousThread) here. Unfortunately it becomes complex to duplicate that logic (requires Unsafe apis)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialogue didn't behave well in systems using classloaders which must be unloaded later.
After this PR
==COMMIT_MSG==
Dialogue attempts not to retain context classloaders
==COMMIT_MSG==
Possible downsides?
The cleaner thread is no longer named something that points to dialogue. We could use the same ThreadFactory utility that I adopted elsewhere, however the cleaner is the most important thread to clean up (the others will expire) and the default constructor uses an internal
InnocuousThreadimplementation which does an even better job of avoiding holding external references.