-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a sticky session interface for multiple client interfaces #1986
Conversation
Generate changelog in
|
* Represents a single session of {@link StickyChannelFactory2} where the underlying channel will not change. | ||
* This is useful when multiple client interfaces must be bound to use the same host. | ||
*/ | ||
public interface StickyChannelSession { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming: should this interface have a 2 somewhere? Unlike the sticky channels factory, it is meant to be stored for reuse, so there's upside to having a cleaner name. I don't have a strong opinion either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at this point it might be time to remove the previous sticky channel implementation, that was the plan all along. 2+ seems enough to prove out it's correctness? :P
Channel getStickyChannel(); | ||
|
||
<T> T sticky(Class<T> clientInterface); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered naming these getChannel
and create(Class<T> clientInterface)
since the interface name implies sticky, but figured matching the sticky factory would be a bit more obvious for readers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot how this code works, I thought it would be harder to knock out. THanks!
Released 3.89.0 |
==COMMIT_MSG==
Implement a sticky session interface for multiple client interfaces
==COMMIT_MSG==