Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate squareup javapoet to Palantir javapoet #2410

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

ash211
Copy link
Contributor

@ash211 ash211 commented Nov 5, 2024

Before this PR

The square version is deprecated and the Palantir one has fixes, including https://github.com/square/javapoet/pull/828 which was never released on square's coordinates but was on Palantir's.

After this PR

==COMMIT_MSG==
Migrate squareup javapoet to Palantir javapoet
==COMMIT_MSG==

Possible downsides?

None known

@changelog-app
Copy link

changelog-app bot commented Nov 5, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Migrate squareup javapoet to Palantir javapoet

Check the box to generate changelog(s)

  • Generate changelog entry

@ash211 ash211 marked this pull request as ready for review November 5, 2024 07:15
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bulldozer-bot bulldozer-bot bot merged commit 295373d into develop Nov 5, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the aash/javapoet-migration branch November 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants