Fix #2812

[nakulj]

Before this PR

Tests miss the case when a method is called on the built string, see #2812

After this PR

Parens are now surround the append result, ensuring that the post-build method call is applied to the entire built string, not just the last element.

Possible downsides?

Adds parens even when unnecessary. These can be caught and fixed by UnnecessaryParentheses, but ideally they'd only be added if necessary.

[palantirtech]

Thanks for your interest in palantir/gradle-baseline, @nakulj! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Add a test case to StringBuilderConstantParametersTests

Check the box to generate changelog(s)

• Generate changelog entry

[pkoenig10]

I don't think it's desirable to unconditionally wrap the suggested fix with parenthesis. This will result in unidiomatic code in the common case.

[nakulj]

Do you have any suggestions on how to check if the parens are necessary?

[pkoenig10]

Sorry, I don't have any suggestions. I suspect this is fairly non-trivial.

I'm not sure it's worthwhile to fix this issue - I imagine it would significantly complicated the logic here.

[nakulj]

Yeah, it seems pretty hard.
That said it seems to me that unidiomatic code is preferable to incorrect code- which is what the fixer currently suggests, especially since UnnecessaryParentheses will automatically catch and fix the unidiomatic generated code.