-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for OpenJDK Early Access builds #423
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
Invalidated by push of 079a9a0
i think this might still need some tweaking to allow the base URL to be correctly overridden in certain scenarios |
@@ -24,7 +24,8 @@ | |||
public enum JdkDistributionName { | |||
AZUL_ZULU, | |||
AMAZON_CORRETTO, | |||
GRAALVM_CE; | |||
GRAALVM_CE, | |||
LOOM_EA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than loom EA specifically, can we just have one for all OpenJDK EAs (and have loom in the version string?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is in the version string? 24-loom+7-60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think I can make this work. The URLs are ever so slightly different for e.g. JDK24 EA builds versus project-specific builds, but I think we can work around that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with DNM to unblock a release candidate
…JDK distributions
2afb872
to
7c75fc6
Compare
Invalidated by push of 7c75fc6
[skip ci]
Invalidated by push of 2c42aef
Before this PR
Only Zulu, Corretto, and Graal CE are supported
After this PR
==COMMIT_MSG==
add support for OpenJDK Early Access builds
==COMMIT_MSG==
Possible downsides?
Early Access builds should really only be used for experimentation at the moment. However it may be generally advantageous to have this pattern available for future EA builds from OpenJDK projects (e.g. Valhalla or any as-yet-unreleased OpenJDK build, which could be used for prototyping before features land in a full JDK release).