fix issue #975: last character not a \n
after format in Intellij
#1113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
WHEN creating a new java class using Intellij with palantir-java-format plugin enabled for formating all java files
AND using maven-spotless with palantirJavaFormat
AND the last line in a java file is not an empty line but just } with no
\n
appendedTHEN the
mvn spotless:check
using palantirJavaFormat failsBECAUSE the Intellij with palantir-java-format plugin enabled does NOT add this required
\n
After this PR
fixes : #975
change
PalantirJavaFormatFormattingService.java
fromrequest.onTextReady(formattedText);
torequest.onTextReady(formattedText.trim() + "\n");
so that the required\n
is added when Intellij formats a source filePossible downsides?