Dedupe reviewers before submitting them to GitHub (#856)

Co-authored-by: Max Schwenk <[email protected]>
palantir · Oct 3, 2024 · 2c98d7d · 2c98d7d
1 parent 5641eea
commit 2c98d7d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/server/handler/eval_context_reviewers.go b/server/handler/eval_context_reviewers.go
@@ -17,6 +17,7 @@ package handler
 import (
 	"context"
 	"math/rand"
+	"slices"
 	"time"
 
 	"github.com/google/go-github/v65/github"
@@ -151,5 +152,11 @@ func selectionToReviewersRequest(s reviewer.Selection) github.ReviewersRequest {
 		req.TeamReviewers = []string{}
 	}
 
+	// Order the reviewers and remove any duplicates because the Github API will error on duplicates as of Oct 2024
+	slices.Sort(req.Reviewers)
+	req.Reviewers = slices.Compact(req.Reviewers)
+	slices.Sort(req.TeamReviewers)
+	req.TeamReviewers = slices.Compact(req.TeamReviewers)
+
 	return req
 }