New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Permission.reverse() keep object identity #47

Open

deeplook wants to merge 1 commit into pallets-eco:main from deeplook:master

deeplook commented Dec 2, 2016

This will swap needs and excludes while returning the same changed Permission object without changed object identity.


          Make Permission.reverse() return self rather than new Permission with…

32511e0

… different object identity

Author

deeplook commented Dec 2, 2016

Post-PR thought: Why not just swap things like this: self.needs, self.excludes = self.excludes, self.needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet