Fix arrow groupby na #60777
Open
Fix arrow groupby na #60777
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
3 times, most recently
from
ac8116b to
0e61611
Compare
asharmalik19
force-pushed
the
fix-arrow-groupby-na
branch
from
0e61611 to
66330ee
Compare
rhshadrach
requested changes
Jan 30, 2025
Comment on lines
+1212
to
+1213
| # dictionary encode does nothing if an already encoded array is given | ||
| data = data.cast(data.type.value_type) |
There was a problem hiding this comment.
I think you're explaining why you have the cast here, but I'm not quite understanding it. Can you give a bit more details (just as a response here, and we can decide if the comment should be updated later).
Comment on lines
+618
to
+619
| - Fixed bug in :meth:`ArrowExtensionArray.factorize` where NA values were dropped when input was dictionary-encoded even when dropna was set to False(:issue:`60567`) | ||
|
|
There was a problem hiding this comment.
Can you move this to an appropriate section below, I think ExtensionArray.
| @@ -3330,6 +3330,19 @@ def test_factorize_chunked_dictionary(): | |||
| tm.assert_index_equal(res_uniques, exp_uniques) | |||
|
|
|||
|
|
|||
| def test_factorize_dictionary_with_na(): | |||
| # Test that factorize properly handles NA values in dictionary arrays | |||
There was a problem hiding this comment.
Can you start the test with a comment referencing the issue, e.g.
# GH#60567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile for the bug fix.