TST(string dtype): Resolve xfails in pytables #60795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Testing
rhshadrach
commented
Jan 26, 2025
5 tasks
rhshadrach
commented
Jan 29, 2025
Comment on lines
+257
to
+260
| if using_infer_string: | ||
| # TODO: Test is incorrect when not using_infer_string. | ||
| # Should take the last 4 rows uncondiationally. | ||
| expected = expected[16:] |
There was a problem hiding this comment.
Would like to make sure this is correct.
…xfail_pytable_misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Looks like using
wherethat results in empty will still give object dtype. xfailing those tests here and plan to tackle in a followup.