Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable get-attr-with-constant (B009) #60862

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Enable get-attr-with-constant (B009) #60862

merged 2 commits into from
Feb 6, 2025

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Feb 6, 2025

The original reasoning to disable this rule is because getattr is needed to side step mypy, but mypy doesn't complain about the fix anymore.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@tqa236 tqa236 requested a review from attack68 as a code owner February 6, 2025 07:42
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Feb 6, 2025
@mroeschke mroeschke added this to the 3.0 milestone Feb 6, 2025
@mroeschke mroeschke merged commit 86c2668 into pandas-dev:main Feb 6, 2025
37 of 46 checks passed
@mroeschke
Copy link
Member

Thanks @tqa236

@tqa236 tqa236 deleted the enable-b009 branch February 6, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@attack68 attack68 Awaiting requested review from attack68 attack68 is a code owner

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tqa236 @mroeschke