Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #60875 on branch 2.3.x (TST/CI: Address enforced numpy DeprecationWarning in test_pandas_dtype_numpy_warning) #60878

Merged
merged 1 commit into from
Feb 7, 2025
+15 −5
Merged

Backport PR #60875 on branch 2.3.x (TST/CI: Address enforced numpy DeprecationWarning in test_pandas_dtype_numpy_warning) #60878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas/core/dtypes/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,6 +1654,8 @@ def pandas_dtype(dtype) -> DtypeObj:
# raise a consistent TypeError if failed
try:
with warnings.catch_warnings():
# TODO: warnings.catch_warnings can be removed when numpy>2.2.2
# is the minimum version
# GH#51523 - Series.astype(np.integer) doesn't show
# numpy deprecation warning of np.integer
# Hence enabling DeprecationWarning
Expand Down
18 changes: 13 additions & 5 deletions pandas/tests/dtypes/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import pandas._testing as tm
from pandas.api.types import pandas_dtype
from pandas.arrays import SparseArray
from pandas.util.version import Version


# EA & Actual Dtypes
Expand Down Expand Up @@ -788,11 +789,18 @@ def test_validate_allhashable():

def test_pandas_dtype_numpy_warning():
# GH#51523
with tm.assert_produces_warning(
DeprecationWarning,
check_stacklevel=False,
match="Converting `np.integer` or `np.signedinteger` to a dtype is deprecated",
):
if Version(np.__version__) <= Version("2.2.2"):
ctx = tm.assert_produces_warning(
DeprecationWarning,
check_stacklevel=False,
match=(
"Converting `np.integer` or `np.signedinteger` to a dtype is deprecated"
),
)
else:
ctx = tm.external_error_raised(TypeError)

with ctx:
pandas_dtype(np.integer)


Expand Down
Loading