Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Handle line and bar on the same plot #61173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BUG: Handle line and bar on the same plot #61173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3caf8e6
Handle line and box on the same plot
MartinBraquet Mar 24, 2025
97d0440
Handle line and box on the same plot
MartinBraquet Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@

from pandas.io.formats.printing import pprint_thing
from pandas.plotting._matplotlib import tools
from pandas.plotting._matplotlib.converter import register_pandas_matplotlib_converters
from pandas.plotting._matplotlib.converter import (
PeriodConverter,
register_pandas_matplotlib_converters,
)
from pandas.plotting._matplotlib.groupby import reconstruct_data_with_by
from pandas.plotting._matplotlib.misc import unpack_single_str_list
from pandas.plotting._matplotlib.style import get_standard_colors
Expand Down Expand Up @@ -1855,7 +1858,6 @@ def __init__(
self.bar_width = width
self._align = align
self._position = position
self.tick_pos = np.arange(len(data))

if is_list_like(bottom):
bottom = np.array(bottom)
Expand All @@ -1868,6 +1870,14 @@ def __init__(

MPLPlot.__init__(self, data, **kwargs)

if isinstance(data.index, ABCPeriodIndex):
self.ax.freq = data.index.freq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the modification of freq necessary? I worry that we don't own ax, and that we shouldn't be mutating it. But I'm not too familiar with the plotting code; do we do this anywhere else? I don't see any instances at a glance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason is to pass the freq to PeriodConverter, which currently only accepts ax as input arg, not freq. It can obviously be made cleaner. I meant to modify PeriodConverter or find a cleaner way than hacking around ax.

I'd just like to get a thorough review of the overall approach, i.e. shifting the tick positions, as it would apply to all box plots with PeriodIndex, and hence is a potential major change. Not sure how well it is covered by tests currently; I don't want to insert regressions or breaking changes. It would be good to have it first checked by a maintainer well-versed with matplotlib, as I'm not so familiar with all the idiosyncrasies of the ax object.

self.tick_pos = np.array(
PeriodConverter.convert(data.index._mpl_repr(), None, self.ax)
)
else:
self.tick_pos = np.arange(len(data))

@cache_readonly
def ax_pos(self) -> np.ndarray:
return self.tick_pos - self.tickoffset
Expand Down