Refactor Block
#10913
Draft
Refactor Block
#10913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Sep 17, 2024
Comment on lines
-128
to
-153
| /// Returns whether or not the block contains any blob transactions. | ||
| #[inline] | ||
| pub fn has_blob_transactions(&self) -> bool { | ||
| self.body.iter().any(|tx| tx.is_eip4844()) | ||
| } | ||
|
|
||
| /// Returns whether or not the block contains any EIP-7702 transactions. | ||
| #[inline] | ||
| pub fn has_eip7702_transactions(&self) -> bool { | ||
| self.body.iter().any(|tx| tx.is_eip7702()) | ||
| } | ||
|
|
||
| /// Returns an iterator over all blob transactions of the block | ||
| #[inline] | ||
| pub fn blob_transactions_iter(&self) -> impl Iterator<Item = &TransactionSigned> + '_ { | ||
| self.body.iter().filter(|tx| tx.is_eip4844()) | ||
| } | ||
|
|
||
| /// Returns only the blob transactions, if any, from the block body. | ||
| #[inline] | ||
| pub fn blob_transactions(&self) -> Vec<&TransactionSigned> { | ||
| self.blob_transactions_iter().collect() | ||
| } | ||
|
|
||
| /// Returns an iterator over all blob versioned hashes from the block body. | ||
| #[inline] |
There was a problem hiding this comment.
none of those should be removed I think
There was a problem hiding this comment.
I moved them to BlockBody, but I'll keep them and call the BlockBody's methods.
Comment on lines
-237
to
-241
| /// Returns an iterator over all transactions in the block. | ||
| #[inline] | ||
| pub fn transactions(&self) -> impl Iterator<Item = &TransactionSigned> + '_ { | ||
| self.block.body.iter() | ||
| } |
There was a problem hiding this comment.
similarly, will reinstate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10907