Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OptimismHardfork to new crate reth_optimism_forks #10963

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 17, 2024

Closes #10518

  • Adds crate reth-optimism-forks
  • Moves reth_ethereum_forks::OptimismHardfork and reth_ethereum_forks::OptimismHardforks to reth-optimism-forks

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth labels Sep 17, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, but I wonder if this breaks --dev mode for op

pub static DEV: Lazy<Arc<ChainSpec>> = Lazy::new(|| {
ChainSpec {
chain: Chain::dev(),
genesis: serde_json::from_str(include_str!("../res/genesis/dev.json"))
.expect("Can't deserialize Dev testnet genesis json"),
genesis_hash: once_cell_set(DEV_GENESIS_HASH),
paris_block_and_final_difficulty: Some((0, U256::from(0))),
hardforks: DEV_HARDFORKS.clone(),

@emhane
Copy link
Member Author

emhane commented Sep 17, 2024

that makes sense, but I wonder if this breaks --dev mode for op

pub static DEV: Lazy<Arc<ChainSpec>> = Lazy::new(|| {
ChainSpec {
chain: Chain::dev(),
genesis: serde_json::from_str(include_str!("../res/genesis/dev.json"))
.expect("Can't deserialize Dev testnet genesis json"),
genesis_hash: once_cell_set(DEV_GENESIS_HASH),
paris_block_and_final_difficulty: Some((0, U256::from(0))),
hardforks: DEV_HARDFORKS.clone(),

let me try :)

@emhane emhane requested a review from mattsse September 17, 2024 15:50
@emhane
Copy link
Member Author

emhane commented Sep 18, 2024

re-request review @mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, incremental progress.

one q re CI change, otherwise lgtm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to change this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of the parse_dev test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove that, not worth changing the ci for and adding a single expectation in ci

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then I have to remove the whole test

@emhane emhane added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 6608968 Sep 20, 2024
36 checks passed
@emhane emhane deleted the emhane/op-hf branch September 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move OptimismHardfork to reth-optimism-chainspec
2 participants