Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): use FullNodeComponents::Network in EthApiBuilderCtx #10996

Merged
merged 5 commits into from
Sep 20, 2024
Merged

chore(rpc): use FullNodeComponents::Network in EthApiBuilderCtx #10996

merged 5 commits into from
Sep 20, 2024
+4 −5

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 18, 2024

Access network type via FullNodeComponents::Network as opposed to a separate generic.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Sep 18, 2024
mattsse
mattsse approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic clippy

@emhane emhane added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 884c74d Sep 20, 2024
35 checks passed
@emhane emhane deleted the emhane/network-fullnodecomps branch September 20, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse