Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an empty static file should be kept unless its related blocks are all unwound #11021

Closed
wants to merge 1 commit into from

Conversation

alexgao001
Copy link
Contributor

In the scenario where we have a static file static_file_receipts_500000_999999, block 500000 contains no transaction receipts, while block 500001 has one transaction. When we trigger an unwind to block 500000, the static file is deleted even though the range of blocks has not been fully pruned yet.

When attempting to restart or unwind further, encounter the following error:

Error: nippy jar error: failed to open file "./datadir/static_files/static_file_receipts_500000_999999.conf": No such file or directory (os error 2)

This fix allows a static file to exist even if it contains no transactions.

@joshieDo
Copy link
Collaborator

appreciate raising this issue!

closing in favor of #11029 , since although this would solve this immediate issue, it would skip the desired file deletion for headers, along some other issues

@joshieDo joshieDo closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants