Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: replace reth-primitive imports with alloy-eips #11027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

estensen
Copy link
Contributor

Progress on #10749

@estensen
Copy link
Contributor Author

Removing this unused import leads to this

error[E0432]: unresolved import `alloy_eips`
  --> crates/net/eth-wire/tests/fuzz_roundtrip.rs:51:9
   |
51 |     use alloy_eips::BlockHashOrNumber;
   |         ^^^^^^^^^^ use of undeclared crate or module `alloy_eips`
   |
help: there is a crate or module with a similar name
   |
51 |     use alloy_rlp::BlockHashOrNumber;
   |         ~~~~~~~~~

@@ -108,7 +108,7 @@ impl TestDownload {
let request = HeadersRequest {
limit: self.limit,
direction: HeadersDirection::Rising,
start: reth_primitives::BlockHashOrNumber::Number(0), // ignored
start: alloy_eips::BlockHashOrNumber::Number(0), // ignored
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can probably use 0u64.into() here

@onbjerg
Copy link
Member

onbjerg commented Sep 20, 2024

Removing this unused import leads to this

error[E0432]: unresolved import `alloy_eips`
  --> crates/net/eth-wire/tests/fuzz_roundtrip.rs:51:9
   |
51 |     use alloy_eips::BlockHashOrNumber;
   |         ^^^^^^^^^^ use of undeclared crate or module `alloy_eips`
   |
help: there is a crate or module with a similar name
   |
51 |     use alloy_rlp::BlockHashOrNumber;
   |         ~~~~~~~~~

you need to demote it to a dev dependency instead, it's used in a test

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants