Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): add test cases for Header truncation #11048

Merged
merged 7 commits into from
Sep 20, 2024
Merged

chore(storage): add test cases for Header truncation #11048

merged 7 commits into from
Sep 20, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Sep 19, 2024 •
edited
Loading

stacked on #11043

Adds test cases for StaticFileSegment::Headers truncation.

Lead to finding a bug that was resulting in not updating the inner index of StaticFileProvider on Case 2 .

Transactions/Receipts will be done alongside #11043 once this and the blocking PR are merged

@joshieDo joshieDo added C-test A change that impacts how or what we test A-static-files Related to static files labels Sep 19, 2024
@joshieDo joshieDo added the C-bug An unexpected or incorrect behavior label Sep 19, 2024
Base automatically changed from joshie/findrange to main September 19, 2024 17:48
@joshieDo joshieDo mentioned this pull request Sep 20, 2024
Merged
shekhirin
shekhirin approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests good

@joshieDo joshieDo added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 05f862a Sep 20, 2024
36 checks passed
@joshieDo joshieDo deleted the joshie/sftests branch September 20, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

@mattsse mattsse Awaiting requested review from mattsse

Assignees
No one assigned
Labels
A-static-files Related to static files C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @shekhirin