Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ChainSpec AT to EngineTypes #11054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Sep 19, 2024

Currently we use concrete chainspec on EngineTypes, we need to change that to make it possible to make engine generic over chainspec.

This could be approached differently with a generic on EngineTypes — I don't have strong opinion here, though adding it as a generic would require additional generic on engine types which I think would be nice to avoid

Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit double up, like an indicator we need to take a step back, and revise the overall design, make a dependency graph. what's the complete list of type that need chainspec associated type? does payload builder need it too for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants