fewer clippy warnings #11
Conversation
andrewgazelka
force-pushed
the
fewer-clippy-warnings
branch
from
11b7a10 to
51f749d
Compare
There was a problem hiding this comment.
One change; also I suspect the issue you were having with missing safety blocks is called by instances of unsafe in the macros that don't have safety comments (Ctrl+F for "unsafe" in lib.rs to find them, there's a few and GitHub won't let me make a comment on a line of code that wasn't changed in this PR).
| impl $name { | ||
| const VARIANT_COUNT: usize = $crate::enum_impl!(COUNT $fst_field $(,$field)*); | ||
| } | ||
|
|
||
| #[allow(clippy::undocumented_unsafe_blocks, clippy::use_self)] |
There was a problem hiding this comment.
I think it'd be better to document these with a safety comment than put a clippy allowance (unless you tried that and it didn't work?)
There was a problem hiding this comment.
It didn't seem to work for some odd reason. If you want to allocate time to try it and it works for you, I wouldn't mind. It seemed clippy::use_self also had false positives—I couldn't find anywhere I could use Self, but I wouldn't be surprised if I am just dumb.
There was a problem hiding this comment.
I was mainly referring to the clippy::undocumented_unsafe_blocks allowance, which you should be able to resolve by putting a safety comment on this unsafe impl and the others like it.
Also, with the clippy::use_self, it seems like you missed the spot where the usage is happening because I'm still seeing that lint trigger with the allowances you added in.
Background
Description
#[must_use]and#[allow]as appropriateVerification