fix: change data type to float64 #1148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
reviewed
Jan 30, 2025
src/event/format/json.rs
Outdated
Comment on lines
181
to
183
| DataType::Float64 => { | ||
| if schema_version == SchemaVersion::V1 | ||
| && (value.is_number() || (is_parsable_as_number(value))) | ||
| { | ||
| return true; | ||
| } | ||
| value.is_f64() | ||
| } |
There was a problem hiding this comment.
Suggested change
| DataType::Float64 => { | |
| if schema_version == SchemaVersion::V1 | |
| && (value.is_number() || (is_parsable_as_number(value))) | |
| { | |
| return true; | |
| } | |
| value.is_f64() | |
| } | |
| DataType::Float64 if schema_version == SchemaVersion::V1 => { | |
| value.is_number() || is_parsable_as_number(value) | |
| } | |
| DataType::Float64 if schema_version != SchemaVersion::V1 => value.is_f64(), |
de-sh
reviewed
Jan 30, 2025
src/event/format/json.rs
Outdated
| let Value::String(s) = value else { | ||
| return false; | ||
| }; | ||
| s.parse::<f64>().is_ok() || s.parse::<i64>().is_ok() |
There was a problem hiding this comment.
Suggested change
| s.parse::<f64>().is_ok() || s.parse::<i64>().is_ok() | |
| s.parse::<f64>().is_ok() |
all strings containing numbers are parsable as f64
nikhilsinhaparseable
force-pushed
the
perf-test
branch
5 times, most recently
from
f2cc31e to
8b9ce2f
Compare
nikhilsinhaparseable
force-pushed
the
perf-test
branch
from
8b9ce2f to
c1a2e8f
Compare
nikhilsinhaparseable
force-pushed
the
perf-test
branch
from
53415ca to
ca52993
Compare
nikhilsinhaparseable
force-pushed
the
perf-test
branch
from
b1d6bda to
799959b
Compare
nikhilsinhaparseable
force-pushed
the
perf-test
branch
from
0df008d to
dd0ef2b
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
nikhilsinhaparseable
force-pushed
the
perf-test
branch
from
04ae949 to
b8d257e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for strings that can be parsed as numbers