fix: add custom fields for pmeta stream #1280
Conversation
add p_custom_field - p_user_agent = parseable p_format = pmeta
WalkthroughThis PR updates the Changes
Sequence Diagram(s)sequenceDiagram
participant Ingester as Ingest Handler
participant CustomFields as Custom Fields Builder
participant Event as Event Processor
Ingester->>CustomFields: Create HashMap with custom fields
CustomFields-->>Ingester: Return populated HashMap
Ingester->>Event: Call into_event(custom_fields)
Event-->>Ingester: Process event with provided custom fields
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/handlers/http/ingest.rs (1)
127-129: Implement custom fields for pmeta stream.This change adds custom fields to the pmeta stream events by:
- Creating a new HashMap for custom fields
- Setting the user agent to "Parseable"
- Setting the format to the string representation of
LogSource::PmetaThis implementation aligns with the PR objective to enhance the pmeta stream with custom fields.
However, there's a slight inconsistency between the implementation and the PR description:
- PR mentions "parseable" (lowercase) but the code uses "Parseable" (capitalized)
Consider using lowercase "parseable" to maintain consistency with the PR description, or update the PR description to match the implementation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/handlers/http/ingest.rs(3 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
src/handlers/http/ingest.rs (4)
src/event/format/mod.rs (1)
new(126-131)src/event/format/json.rs (1)
new(42-47)src/metadata.rs (1)
new(95-130)src/event/format/known_schema.rs (1)
new(148-168)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: coverage
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
🔇 Additional comments (2)
src/handlers/http/ingest.rs (2)
32-32: New imports added for custom fields.This change imports the necessary constants
FORMAT_KEYandUSER_AGENT_KEYto be used in setting up custom fields for the pmeta stream.
141-141: Pass custom fields to into_event method.This change properly passes the newly created custom fields HashMap to the
into_eventmethod, replacing the previously empty HashMap.
changed user_agent_key to `parseable` to keep it consistent with the user_agent_key used in kafka (all lowercase) Signed-off-by: Nikhil Sinha <[email protected]>
add p_custom_field -
p_user_agent = parseable
p_format = pmeta
Summary by CodeRabbit