Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cookies in session #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions httmock.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ def _fake_send(session, request, **kwargs):
history.insert(0, response)
response = history.pop()
response.history = tuple(history)
for resp in history:
session.cookies.update(resp.cookies)
session.cookies.update(response.cookies)
return response

return self._real_session_send(session, request, **kwargs)
Expand Down
33 changes: 33 additions & 0 deletions tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,39 @@ def response_content(url, request):
self.assertTrue('foo' in r.cookies)
self.assertEqual(r.cookies['foo'], 'bar')

def test_response_cookies_stored_in_session(self):
cookies = 'foo=bar;'

@all_requests
def response_content(url, request):
return response(200, 'Foo', {'Set-Cookie': cookies},
request=request)

session = requests.Session()
with HTTMock(response_content):
r = session.get('https://foo_bar')
self.assertEqual(r.cookies['foo'], 'bar')
self.assertEqual(session.cookies['foo'], 'bar')
cookies = 'baz=qux;'
r = session.get('https://foo_bar')
self.assertTrue('foo' not in r.cookies)
self.assertEqual(session.cookies['foo'], 'bar')
self.assertEqual(session.cookies['baz'], 'qux')

def test_session_cookies_with_redirect(self):
@urlmatch(netloc='example.com')
def get_mock(url, request):
return {'status_code': 302,
'headers': {'Location': 'http://google.com/',
'Set-Cookie': 'foo=bar;'}}

session = requests.Session()
with HTTMock(get_mock, google_mock):
r = session.get('http://example.com/')
self.assertEqual(len(r.history), 1)
self.assertTrue("foo" not in r.cookies)
self.assertTrue("foo" in session.cookies)

def test_python_version_encoding_differences(self):
# Previous behavior would result in this test failing in Python3 due
# to how requests checks for utf-8 JSON content in requests.utils with:
Expand Down