feat(TableMessage): Add support for PatternFly tables #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 3, 2025
|
Preview: https://chatbot-pr-chatbot-425.surge.sh A11y report: https://chatbot-pr-chatbot-425-a11y.surge.sh |
rebeccaalpert
force-pushed
the
tables
branch
2 times, most recently
from
e62c8ac to
73435c1
Compare
rebeccaalpert
force-pushed
the
tables
branch
2 times, most recently
from
28aef09 to
9fc7519
Compare
edonehoo
requested changes
Feb 4, 2025
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
…mples/Messages/BotMessage.tsx Co-authored-by: Erin Donehoo <[email protected]>
thatblindgeye
requested changes
Feb 10, 2025
There was a problem hiding this comment.
In addition to the file comments below, a non-blocker for this PR would be switching from radio buttons for these examples and using a Select instead -- would reduce the space taken up, but would also allow more unique labeling for the Selects (right now there's basically 2+ radio buttons with the same labels on the page: 2 for "Table" etc). Again non-blocking here if we wanted to open a followup for a docs update.
|
Opening #433 for Select switch. |
rebeccaalpert
force-pushed
the
tables
branch
from
d3477d4 to
23962de
Compare
thatblindgeye
approved these changes
Feb 10, 2025
nicolethoen
approved these changes
Feb 11, 2025
|
🎉 This PR is included in version 2.2.0-prerelease.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire Message to re-route tables to PF tables.
These are just basic tables, with no bells and whistles. I am defaulting to the mobile breakpoint, but we could also do a regular table at certain widths. Let me know what you want to do here - I am just copying Figma right now. I am also letting this be full width, but it will resize down if you change the device viewport or screen size - let me know if that's not what we want.
I am defining a default aria label, allowing passage of aria-labels, and also attempting to generate these based on headers. I have written tests for full tables, blank tables, headerless tables, cell-less tables, 1 column-tables, and 1-cell tables. Let me know if you can break this and we'll add another test.
Doc changes: