Skip to content

Commit

Permalink
fix: remove fsevents from docs and JSDoc
Browse files Browse the repository at this point in the history
Removes `fsevents` from the current documentation and the JSDoc/types.
  • Loading branch information
43081j committed Sep 19, 2024
1 parent 9b15d99 commit bad7dce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,7 @@ recursively.
#### Persistence

* `persistent` (default: `true`). Indicates whether the process
should continue to run as long as files are being watched. If set to
`false` when using `fsevents` to watch, no more events will be emitted
after `ready`, even if the process continues to run.
should continue to run as long as files are being watched.

#### Path filtering

Expand Down Expand Up @@ -180,10 +178,6 @@ to true (1) or false (0) in order to override this option.
* `binaryInterval` (default: `300`). Interval of file system
polling for binary files.
([see list of binary extensions](https://github.com/sindresorhus/binary-extensions/blob/master/binary-extensions.json))
* `useFsEvents` (default: `true` on MacOS). Whether to use the
`fsevents` watching interface if available. When set to `true` explicitly
and `fsevents` is available this supercedes the `usePolling` setting. When
set to `false` on MacOS, `usePolling: true` becomes the default.
* `alwaysStat` (default: `false`). If relying upon the
[`fs.Stats`](https://nodejs.org/api/fs.html#fs_class_fs_stats)
object that may get passed with `add`, `addDir`, and `change` events, set
Expand Down Expand Up @@ -254,7 +248,7 @@ execute a command on each change, or get a stdio stream of change events.
`Error: watch /home/ ENOSPC`
* This means Chokidar ran out of file handles and you'll need to increase their count by executing the following command in Terminal:
`echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p`
* Upgrade to latest chokidar, to prevent fsevents-related issues:
* If using 3.x, upgrade to latest chokidar to prevent fsevents-related issues:
* `npm WARN optional dep failed, continuing [email protected]`
* `TypeError: fsevents is not a constructor`

Expand Down
5 changes: 3 additions & 2 deletions src/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,15 @@ const FsWatchInstances = new Map<string, FsWatchContainer>();
* @param listener main event handler
* @param errHandler emits info about errors
* @param emitRaw emits raw event data
* @returns new fsevents instance
* @returns {NativeFsWatcher}
*/
function createFsWatchInstance(
path: string,
options: Partial<FSWInstanceOptions>,
listener: WatchHandlers['listener'],
errHandler: WatchHandlers['errHandler'],
emitRaw: WatchHandlers['rawEmitter']
) {
): NativeFsWatcher | undefined {
const handleEvent: WatchListener<string> = (rawEvent, evPath: string | null) => {
listener(path);
emitRaw(rawEvent, evPath!, { watchedPath: path });
Expand All @@ -169,6 +169,7 @@ function createFsWatchInstance(
);
} catch (error) {
errHandler(error);
return undefined;
}
}

Expand Down

0 comments on commit bad7dce

Please sign in to comment.