test: switch to node test runner #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
commented
May 25, 2024
|
looks like tests are failing on windows quite often 😞 its late, ill have a look some other time soon |
Switches to using the built-in node test runner and drops mocha. Temporarily also introduces a `TEST_TIMEOUT` as `--test-timeout` is only available in 20.x and above, but we run CI in 18.x.
|
all good? |
|
there's some flakiness/timing problem with the tests on windows when we use node's runner i have a pretty hectic weekend but ill try pick it up soon and let you know |
Adds a small delay in some tests after the initial path has been added (to avoid the FS de-duping/cancelling events).
|
seems we have a passing test run! on my fork, CI still fails every now and then for this test: its a failed assertion rather than a timeout, so i will try investigate it more as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using the built-in node test runner and drops mocha.
Temporarily also introduces a
TEST_TIMEOUTas--test-timeoutis only available in 20.x and above, but we run CI in 18.x.