fix: remove jsdoc types and improve internal types #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talentlessguy
commented
Sep 18, 2024
| */ | ||
| close() { | ||
| close(): Promise<void> | undefined { |
There was a problem hiding this comment.
@benmccann this._closePromise may be undefined, should we return undefined as well, or use a non-null assertion?
There was a problem hiding this comment.
I didn't get to look at this before it was merged, but to answer your question I think Promise<void> is the correct return type here and we should not return undefined. I've opened a new issue to discuss it: #1357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #1355