Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Replace error type with ones more like std #544

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Sep 1, 2022

A start towards #49, though I haven't audited panicking, just migrated the existing errors.

Notably, because the error type no longer holds String, the crate no longer has a hard requirement on alloc.

@paupino
Copy link
Owner

paupino commented Sep 2, 2022

Thank you for this! I'll need to start a v2 branch to start API breaking changes. There are a few things I'd ultimately like to address/clean up for v2 while at the same time still be able to bug fix any smaller issues on the v1 branch.

For the meantime, I'll leave this open and once I create a v2 branch we'll see if we can retarget it and perform a full review. There are a couple of v1 changes I'd like to get in before creating the branch (just to make it easier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants