Implement traits on the ArchivedDecimal. #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkyv generates a separate type `ArchivedDecimal`, which represents the serialized value. In this PR we implement several traits to allow for ordering and equality traits on the ArchivedDecimal type (according to the rules of the Decimal type). We also implement comparison between `Decimal` and `ArchivedDecimal` (PartialOrd) which is helpful to efficiently compare e.g., a more complex in-memory type that uses decimal with it's serialized counter-part like something that's stored on-disk. Signed-off-by: Gerd Zellweger <[email protected]>
This was referenced Jan 15, 2024
|
hi, is there anything I can do to move this PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rkyv generates a separate type
ArchivedDecimal, which represents the serialized value. In this PR we implement several traits to allow for ordering and equality on theArchivedDecimaltype (according to the rules of the Decimal type).We also implement comparison between
DecimalandArchivedDecimal(PartialOrd) which is helpful to efficiently compare e.g., a more complex in-memory type that uses decimal as part of its fields with the serialized counter-part.