Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros: remove circular dependency from macros feature #644

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

paupino
Copy link
Owner

@paupino paupino commented Feb 2, 2024

This revisits the previous macro feature and removes the dependency on rust-decimal for parsing the string. Consequently, macros and rust decimal can be decoupled and delivered independently.

There may be a small regression in performance so I'm keeping this in draft as I diagnose.

New bench:

running 2 tests
test decimal_from_str            ... bench:          90 ns/iter (+/- 2)
test decimal_scientific_from_str ... bench:         265 ns/iter (+/- 8)

Old bench:

test decimal_from_str            ... bench:          69 ns/iter (+/- 1)
test decimal_scientific_from_str ... bench:         198 ns/iter (+/- 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant