Update vault pre-render to support customerId check #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
May 1, 2024
jshawl
approved these changes
May 1, 2024
There was a problem hiding this comment.
Not sure why the lint failure appeared out of no where but @imbrian submitted a fix for this in common-components: paypal/paypal-common-components#99
elizabethmv
force-pushed
the
update-vault-prerender
branch
from
f6a88da to
03e544d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the pre-render experience to account for a customerId (on SDK token) to ensure that the UX reflects whether we are attempting to render the vaulted button.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
This improve the UX to ensure we do not show that shimmer experience when we know we are not able to.
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
SDK client changes with to get the customer Id were released
Groups who should review (if applicable)